I tested both samples now.
They work both, but have the same heavy yellow shift when opend in PS. (It's an old Canon 7D cr2 by the way.) The exported thumbnail had not.
And, even with the heavy yellow shift, the values do not match... In 8 and 16 bit mode....
The first pixel of the ppm file in PS has RGB(54, 64, 14).
The first pixel of my xls has
RGBG2(542,1052,418,874) from .imgdata.image[pos][], or
RGB(22,34,18) from image->data[]
And also:
data field in libraw_processed_image_t is 'unsigned char', while you're using 16-bit output.
So you dump 8-bit wise pieces, not real 16-bit values.
Well, I loaded the image as shown in my code. I know, PS/LR have some hidden adjustments.
The first 100x100 pixel in the image, listed in the xls, are supposed to be some kind of green. Leaves and treetops.
But all data listed is not near the RGB values for green. And furthermore these values are supposed be in a neare range of greens. But all listed data seem to jump all over the place.
I tried both, 8 and 16 bits for the output, and other different modes in the params. But nothing worked for me.
Yes, I know that the rawdata has a larger field then the final RGB values. This is just some kind of "test" to see a reason for that jumping values.
The fixed vs variable contrast indeed seems to be the major contributing factor to the difference. I'm not familiar with that terminology; could you explain what variable contrast mode does? Can LibRaw emulate it?
I think you need to build LibRaw with
-DUSE_JPEG (to handle jpeg-compressed files, like 'fast load DNG' and some old Kodaks)
-DUSE_ZLIB (to handle deflate-compressed floating point DNG files)
These settings will handle "99%" of today RAW files.
So libjpeg and libz to be distributed with libraw(.dll)
imgdata.image is 16 bit/linear
image->data is 16 bit (output_bps set to 16) and gamma corrected (as far as I could understand from your code)
Both imgdata.image and image.data are cropped (by imgdata.sizes top/left_margin and width/height), while imgdata.rawimage.* is not cropped.
Also, imgrata.rawimage contains unaltered raw values, black level not subtracted
I have now released the lib for general use under https://github.com/lanthale/librawfx. Thank you allot for your help with the compilation and accessing the raw RGB data.
Thank you for the hint. I managed now to get the data but actually the resulted image is greyscale and cut off but the root cause could be something different. I will post some code here after it works to help people using the java foreign memory api.
I have now tried the osx binary.zip file but I does not build at all (./configure was fine, but make had issues)
libraw-osx % make
cd . && /bin/sh automake --foreign
/usr/local/bin/automake: line 23: package: command not found
/usr/local/bin/automake: line 25: use: command not found
/usr/local/bin/automake: line 26: use: command not found
/usr/local/bin/automake: line 27: use: command not found
/usr/local/bin/automake: line 29: BEGIN: command not found
/usr/local/bin/automake: automake: line 31: syntax error near unexpected token `@INC,'
/usr/local/bin/automake: automake: line 31: ` unshift (@INC, '/usr/local/Cellar/automake/1.16.3/share/automake-1.16')'
make: *** [Makefile.in] Error 1
Then I tried a github checkout:
This time I could build with configure and make but the result is always under the lib folder "libraw.a" instat of the "libraw.dylib".
Then I tried the same on Ubuntu and ended up as well with "libraw.a".
I tested both samples now.
They work both, but have the same heavy yellow shift when opend in PS. (It's an old Canon 7D cr2 by the way.) The exported thumbnail had not.
And, even with the heavy yellow shift, the values do not match... In 8 and 16 bit mode....
The first pixel of the ppm file in PS has RGB(54, 64, 14).
The first pixel of my xls has
RGBG2(542,1052,418,874) from .imgdata.image[pos][], or
RGB(22,34,18) from image->data[]
Regards.
Samples are in samples/*.cpp in LibRaw distribution.
BTW, in this piece of code
"," << (int) image->data[rgb_pos++] << "," << (int) image->data[rgb_pos++] << "," << (int) image->data[rgb_pos++]Execution order is not specified (before C++17, AFAIK), that may explain garbage output.
Yes, please start from samples. If LibRaw's samples provides expected (visually correct) results that mean that the problem is not within LibRaw.....
Yes, I know, but even in 8 bit mode it did not match. The values seem random to me.
You mean from the samples page? no, not yet. I'll try this and copy this code.
Regards.
And also:
data field in libraw_processed_image_t is 'unsigned char', while you're using 16-bit output.
So you dump 8-bit wise pieces, not real 16-bit values.
Let's start from the beginning.
Have you tried dcraw_emu sample? If so, are results 'expected' or not?
Same question with mem_image sample.....
Thanks for your fast response.
Well, I loaded the image as shown in my code. I know, PS/LR have some hidden adjustments.
The first 100x100 pixel in the image, listed in the xls, are supposed to be some kind of green. Leaves and treetops.
But all data listed is not near the RGB values for green. And furthermore these values are supposed be in a neare range of greens. But all listed data seem to jump all over the place.
I tried both, 8 and 16 bits for the output, and other different modes in the params. But nothing worked for me.
Yes, I know that the rawdata has a larger field then the final RGB values. This is just some kind of "test" to see a reason for that jumping values.
Regards.
You can always double-check what your libraw.dll links against at runtime using the Dependency Walker: https://www.dependencywalker.com/
dcraw.c's postprocessing (LibRaw::dcraw_process is derived from it) do not have contrast controls.
Thanks for the quick reply, Alex.
The fixed vs variable contrast indeed seems to be the major contributing factor to the difference. I'm not familiar with that terminology; could you explain what variable contrast mode does? Can LibRaw emulate it?
I think you need to build LibRaw with
-DUSE_JPEG (to handle jpeg-compressed files, like 'fast load DNG' and some old Kodaks)
-DUSE_ZLIB (to handle deflate-compressed floating point DNG files)
These settings will handle "99%" of today RAW files.
So libjpeg and libz to be distributed with libraw(.dll)
LibRaw::dcraw_process output is close (enough) to FastRawViewer in fixed contrast + auto ETTR mode.
Could you please ask more specific question?
imgdata.image is 16 bit/linear
image->data is 16 bit (output_bps set to 16) and gamma corrected (as far as I could understand from your code)
Both imgdata.image and image.data are cropped (by imgdata.sizes top/left_margin and width/height), while imgdata.rawimage.* is not cropped.
Also, imgrata.rawimage contains unaltered raw values, black level not subtracted
I have now released the lib for general use under https://github.com/lanthale/librawfx. Thank you allot for your help with the compilation and accessing the raw RGB data.
In the next public snapshot.
When do you anticipate supporting Sony A1 RAW?
Thanks!
Thank you for the hint. I managed now to get the data but actually the resulted image is greyscale and cut off but the root cause could be something different. I will post some code here after it works to help people using the java foreign memory api.
&data[0] is pointer to start of data
Actual data is either 1 or 2 bytes per pixel (depends on imgdata.params.output_bps), no extra padding.
See mem-image.cpp sample, it covers all/most cases (1/3 channels, 8 and 16 bits)
Now I have reinstalled the whole toolchain and now it is working.
Thank you for the hint.
It looks like you have incomplete/broken autotools installation
I have now tried the osx binary.zip file but I does not build at all (./configure was fine, but make had issues)
libraw-osx % make
cd . && /bin/sh automake --foreign
/usr/local/bin/automake: line 23: package: command not found
/usr/local/bin/automake: line 25: use: command not found
/usr/local/bin/automake: line 26: use: command not found
/usr/local/bin/automake: line 27: use: command not found
/usr/local/bin/automake: line 29: BEGIN: command not found
/usr/local/bin/automake: automake: line 31: syntax error near unexpected token `@INC,'
/usr/local/bin/automake: automake: line 31: ` unshift (@INC, '/usr/local/Cellar/automake/1.16.3/share/automake-1.16')'
make: *** [Makefile.in] Error 1
Then I tried a github checkout:
This time I could build with configure and make but the result is always under the lib folder "libraw.a" instat of the "libraw.dylib".
Then I tried the same on Ubuntu and ended up as well with "libraw.a".
How can I get the system to build a shared lib ?
Thank you for the hint. I will download in the evening and will try to use the configure install option and report back how it worked out.
Also you can use LibRaw 0.20 (see Download section on this site) with pre-generated configure stuff.
> But I have to copy Makefile.dist to Makefile.in.
This will not work.
Please use autoreconf --install in full scale.
Pages