Recent comments

Reply to: Pink/purple color cast on Sony A7III ARW file?   5 years 10 months ago

Below is the code I used for processing that Sory A73 ARW file with the pink/purple cast.
Am I doing something wrong?

        LibRaw *rawProcessor = new LibRaw;
        CIImage *ciImage = nil;
        // Set up image processing parameters
        rawProcessor->imgdata.params.half_size = 1;
        rawProcessor->imgdata.params.user_qual = 0;
        rawProcessor->imgdata.params.use_camera_wb = 1;
        rawProcessor->imgdata.params.use_auto_wb = 0;
        rawProcessor->imgdata.params.no_auto_bright = 1;
        rawProcessor->imgdata.params.exp_correc = 1;
        rawProcessor->imgdata.params.exp_shift = 2.3;
        rawProcessor->imgdata.params.use_rawspeed = 0;
        rawProcessor->imgdata.params.user_flip = 0;     // Do not rotate image, let the caller do it
 
        if (rawProcessor->open_file([filePath UTF8String]) == LIBRAW_SUCCESS) {
            int ret = rawProcessor->unpack();
            if (ret == LIBRAW_SUCCESS) {
                ret = rawProcessor->dcraw_process();
                if (ret == LIBRAW_SUCCESS) {
                    libraw_processed_image_t *imageData = rawProcessor->dcraw_make_mem_image(&ret);
                    rawProcessor->recycle();
 
                    // make data provider from buffer
                    CGDataProviderRef provider = CGDataProviderCreateWithData(NULL, imageData->data, imageData->data_size, NULL);
 
                    // set up for CGImage creation
                    int bitsPerComponent = imageData->bits;
                    int bitsPerPixel = imageData->bits * imageData->colors;
                    int bytesPerRow  = bitsPerPixel / 8 * imageData->width;
                    int width = imageData->width;
                    int height = imageData->height;
 
                    CGColorSpaceRef colorSpaceRef = CGColorSpaceCreateDeviceRGB();
                    CGImageRef imageRef = CGImageCreate(width, height, bitsPerComponent, bitsPerPixel, bytesPerRow, colorSpaceRef, kCGBitmapByteOrderDefault, provider, NULL, NO, kCGRenderingIntentDefault);
                    ciImage = [CIImage imageWithCGImage:imageRef];
                    // Free memory
                    CFRelease(colorSpaceRef);
                    CFRelease(imageRef);
                    CFRelease(provider);
                    LibRaw::dcraw_clear_mem(imageData);
                    // Auto adjust image
                    NSDictionary *options = @{ CIDetectorImageOrientation : [NSNumber numberWithInt:1],
                                               kCIImageAutoAdjustRedEye : [NSNumber numberWithBool:NO]};
                    NSArray *adjustments = [ciImage autoAdjustmentFiltersWithOptions:options];
                    for (CIFilter *filter in adjustments) {
                        // Do not apply tone curve, as it can make the contrast too high
                        if ([[filter name] isNotEqualTo:@"CIToneCurve"]) {
                            [filter setValue:ciImage forKey:kCIInputImageKey];
                            ciImage = filter.outputImage;
                        }
                    }
                }
            }
        }
        delete rawProcessor;
        return ciImage;
Reply to: Pink/purple color cast on Sony A7III ARW file?   5 years 10 months ago

We publish master branch twice a year from our internal repository to github. Publushed version is tested in our end-user software (FastRawViewer, RawDigger), so 'decoder part' usually is reliable (and we do not change postprocessing part much for years, because dcraw_process() is only a sample)

Reply to: Pink/purple color cast on Sony A7III ARW file?   5 years 10 months ago

I do not see any problems with LibRaw 0.19.2 and this file (tested with dcraw_emu [-w] from 0.19.2/Windows-64 binary)

Reply to: Pink/purple color cast on Sony A7III ARW file?   5 years 10 months ago

Sorry for the silly question: how reliable is the master (development) branch?

Reply to: Pink/purple color cast on Sony A7III ARW file?   5 years 10 months ago

And followup: it is hard to answer some raw-related questions without file samples.

Reply to: Pink/purple color cast on Sony A7III ARW file?   5 years 10 months ago

A7-III is not supported in LibRaw 0.19
You may consider master (development) branch: https://github.com/LibRaw/LibRaw/

Reply to: Missing option (cfaline)   5 years 10 months ago

GPL2 code: https://github.com/LibRaw/LibRaw-demosaic-pack-GPL2
GPL3 code: https://github.com/LibRaw/LibRaw-demosaic-pack-GPL3

this is abandoned code: it was contributed to LibRaw many years ago, it is not supported by contributor(s), and we (LibRaw team) also unable to support it.

Reply to: Missing option (cfaline)   5 years 10 months ago

Thanks! :)

Could you elaborate on the "-demosaic-pack-GPLn contributed code"? I mean, where can I find it?

Reply to: Missing option (cfaline)   5 years 10 months ago

Revisited it: Docs come with LibRaw tarball/zip are already up-to date. This site documentation page is updated with tarball docs (without any check is it up to date or not)

Reply to: Missing option (cfaline)   5 years 10 months ago

yes, -demosaic-pack-GPLn contributed code is complete decoupled from main LibRaw, so no support for it in main code trunc (one need to use callback inteface for that and/or subclass LibRaw to use this code).

We'll revisit documentation for 'hanging' pieces one more time before 0.19.3 release.

Reply to: Missing option (cfaline)   5 years 10 months ago

Note: same applies to the wf_debanding option

Reply to: LibRaw 0.19.5-Release   5 years 10 months ago

I have RAWs available from the 80D and the 200D:

80D, LibRaw: 6022 x 4020
80D, DCRAW: 6024 x 4022, 2 more cols on the left side, 2 extra rows at the top
80D, DNG-Converter: Same as DCRAW

200D, LibRaw: 6022 x 4020
200D, DCRAW: 6024 x 4020, 2 more cols on the left side of the image
200D, DNG-Converter: Same as DCRAW

Strange that the sizes are equal in DNG-Converter and DCRAW, but different for the two cameras.

Reply to: LibRaw 0.19.5-Release   5 years 10 months ago

Could you please specify what need to be fixed: left/top margin(s), or visible area only?

Reply to: LibRaw 0.19.5-Release   5 years 10 months ago

Hi,

I've noticed that LibRaw decodes 6022 x 4020 Pixels from the sensors used in Canons EOS 80D, 200D, 77D etc.,
while DNG-Converter (and original DCRAW) decode 6024 x 4022 Pixels.
Can this be changed?
I ask because calibration images (darks, flats, bias, bad-pixel maps) for astro imaging cannot be used cross wise.

Greetings, Erwin

Reply to: Canon EOS 2000D   5 years 11 months ago

Thank you very much!

Reply to: Canon EOS 2000D   5 years 11 months ago

New LibRaw-201812 snapshot just published at https://github.com/LibRaw/LibRaw
This version supports 2000D/4000D (and other fresh cameras)

Reply to: Just Demosaic   5 years 11 months ago

Some interpolation methods are based on proper lightness calculation. For these methods, demosaic w/o prior white balance will provide wrong (and visually very bad) results.
Also, data scaling in desirable to lower rounding errors.

Anyway, you may create your own dcraw_process() call without steps that are unnecessary to you. In LibRaw's dcraw_process() there is no way to skip pre-interpolations steps (scale_colors, pre_interpolate) /and after-interpolation convert_to_rgb() is also always executed).

Alternatively, you may fix all processing params via user_* variables.

Reply to: C++ API   5 years 11 months ago

You may use alternate libraries.

Reply to: C++ API   5 years 11 months ago

I looked at the GitHub page for sources, it looks quite messy.

I struggle to put confidence in projects that have obsolete and current file merged together, and many files for nothing. Lack of consistent naming and structure even?

Also the doc made on a forum ?
You should use Doxygen, that would look way more serious.

Thanks for the concept and efforts though

Reply to: Canon EOS 2000D   5 years 11 months ago

Wait a little. We'll publish next snapshot soon (still waiting for Nikon Z6 samples: all crops/all compression methods, to make sure we support this camera in full)

Reply to: Canon EOS 2000D   5 years 11 months ago

I need the patch too. Link is not working for me aswell...

Reply to: CR3 support   6 years 2 days ago

Hi!
How can we help? I can provide images with multiple settings, if that is useful.
If you have other ideas, let me know!

Thanks!

Jose

Reply to: Canon EOS 2000D   6 years 1 week ago

Hi all,

I need the patch for 2000D but the link doesnt work anymore.
Can you please repost the patch.

Thanks

Reply to: Decoding RAW without Bayer interpolation to single greyscale   6 years 2 weeks ago

Thanks developer

Pages