Add new comment

optimisation/bug in convert_to_rgb() ?

I'm wondering if the code in dcraw_common in convert_to_rgb() is wrong...

#ifndef LIBRAW_LIBRARY_BUILD
raw_color |= colors == 1 || document_mode ||
output_color < 1 || output_color > 5;
#else
...

I thought it should be setting libraw_internal_data.internal_output_params.raw_color so that the convert_to_rgb_loop() function would not apply the matrix?

Also I wondered about adding an option to not compute the histogram in that function?

Thanks

Kevin

Forums: