raw-identify bug when displaying Camera2RGB matrix for Sony DSC-F828
This camera produces a RAW file that has a REGB layout which means there are 4 colors. This results in a non-square rgb_cam. However, the display code in raw-identify (v 0.19.6) appears to be incorrect. The code is as below:
for (int i = 0; i < P1.colors; i++)
printf("%6.4f\t%6.4f\t%6.4f\n", C.rgb_cam[i][0], C.rgb_cam[i][1], C.rgb_cam[i][2]);
I believe it should be:
for(int j = 0; j < 3; j++) {
for (int i = 0; i < P1.colors; i++)
printf("%6.4f\t", C.rgb_cam[j][i]);
printf("\n");
}
The same issue persists in 0.20 as well. The incorrect code displays a 4x3 matrix with the last row being the first row of xyz_cam. rgb_cam is 3x4.
Dinesh
Recent comments